TYP: assorted annotations #39798
Merged
TYP: assorted annotations #39798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/algorithms.py
Outdated
| def _take_2d_multi_object(arr, indexer, out, fill_value, mask_info): | ||
| def _take_2d_multi_object( | ||
| arr: np.ndarray, indexer: np.ndarray, out: np.ndarray, fill_value, mask_info | ||
| ): |
There was a problem hiding this comment.
Suggested change
| ): | |
| ): -> None |
(and similarly for some others, while we're here?)
There was a problem hiding this comment.
im ambivalent about the -> None pattern
There was a problem hiding this comment.
why these are easy to annotate
and make it super obvious what is happening
we should always type void
jreback
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
looks fine. small comments can be in a followon.
cc @simonjayhawkins for typing
jreback
reviewed
Feb 17, 2021
| @@ -263,7 +263,7 @@ def _reconstruct_data( | |||
| return values | |||
|
|
|||
|
|
|||
| def _ensure_arraylike(values): | |||
| def _ensure_arraylike(values) -> ArrayLike: | |||
There was a problem hiding this comment.
is_array_like is True for Series and Index so the return type should probably be AnyArrayLike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoid passing unnecesary arg to libreduction, and use a lower-level sanitize function in sanitize_index