CLN: Styler simplify existing builtin methods #39797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jreback
requested changes
Feb 15, 2021
pandas/io/formats/style.py
Outdated
| """ | ||
| Highlight the value in a Series or DataFrame by func with css-properties | ||
| """ | ||
| if highlight == "max": |
There was a problem hiding this comment.
this is extra complicated. just inline the conditionals in the functions themselvs.
attack68
changed the title
jreback
approved these changes
Feb 16, 2021
|
thanks @attack68 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
Styler.applycan acceptndarrayin all cases we can reorganise the module and wrap all the UI facing functions into one: