Skip to content

CLN: Better method of determining read-only status of openpyxl worksheet #39793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

CLN: Better method of determining read-only status of openpyxl worksheet #39793

merged 1 commit into from
Feb 15, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

@rhshadrach rhshadrach added IO Excel read_excel, to_excel Clean labels Feb 13, 2021
@jorisvandenbossche
Copy link
Member

Thanks for following up with openpyxl!

(failure is unrelated resource warning)

@jorisvandenbossche jorisvandenbossche merged commit 9f792cd into pandas-dev:master Feb 15, 2021
@rhshadrach rhshadrach deleted the openpyxl_readonly branch February 15, 2021 09:43
znicholls pushed a commit to znicholls/pandas that referenced this pull request Feb 17, 2021
@rhshadrach @znicholls
CLN: Better method of determining read-only status of openpyxl worksh…
f36b11a 
…eet (pandas-dev#39793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Clean IO Excel read_excel, to_excel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @jorisvandenbossche