CLN: remove redundant openpyxl type conversions #39782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openpyxl already converts cell values to Python types, preferring integers where possible. For backwards-compatibility, we have to convert integers back to float if not `convert_float`
rhshadrach
reviewed
Feb 13, 2021
| elif cell.data_type == TYPE_ERROR: | ||
| return np.nan | ||
| elif cell.data_type == TYPE_BOOL: | ||
| return bool(cell.value) |
There was a problem hiding this comment.
Are there tests for bool/int/etc?
There was a problem hiding this comment.
Yes there are. If I break the function to return
- all numbers as float, 198 tests fail
- all numbers as int, 211 tests fail
- all bools as int, 20 tests fail
- all bools as str, zero tests fail because TextParser does its own conversions
Thanks for taking them time to look at my first pull request. Let me know if there's anything that needs to be improved.
There was a problem hiding this comment.
Great - thanks for checking.
rhshadrach
approved these changes
Feb 13, 2021
| elif cell.data_type == TYPE_ERROR: | ||
| return np.nan | ||
| elif cell.data_type == TYPE_BOOL: | ||
| return bool(cell.value) |
There was a problem hiding this comment.
Great - thanks for checking.
|
thanks @ahawryluk |
znicholls
pushed a commit
to znicholls/pandas
that referenced
this pull request
Feb 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openpyxl already converts cell values to Python types, preferring
integers where possible. For backwards-compatibility, we have to convert
integers back to float if not
convert_float