STYLE, CI move validate_rst_title_capitalization check to pre-commit #39779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 12, 2021
| """ | ||
| The main method to print all headings with incorrect capitalization. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| source_paths : str | ||
| List of directories to validate, provided through command line arguments. | ||
| output_format : str |
There was a problem hiding this comment.
looks like this was unused anyway
MarcoGorelli
force-pushed
the
validate-title-capitalization-pre-commit
branch
from
26e4ba6 to
0899cdf
Compare
MarcoGorelli
commented
Feb 12, 2021
| @@ -233,10 +233,6 @@ if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then | |||
| $BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS02,SS04,SS05,PR03,PR04,PR05,PR10,EX04,RT01,RT04,RT05,SA02,SA03 | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
|
|
|||
| MSG='Validate correct capitalization among titles in documentation' ; echo $MSG | |||
| $BASE_DIR/scripts/validate_rst_title_capitalization.py $BASE_DIR/doc/source/development $BASE_DIR/doc/source/reference | |||
There was a problem hiding this comment.
any reason why this was only run in two directories? I guess it could be expanded now
lithomas1
added
CI
|
thanks @MarcoGorelli |
znicholls
pushed a commit
to znicholls/pandas
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39624 in which it took ~15 minutes for @rhshadrach to be told
, like this such feedback will be provided much faster