BUG: pd.show_versions: json.decoder.JSONDecodeError

[alexprincel]

• [ x] closes BUG: pd.show_versions: json.decoder.JSONDecodeError #39701
• [ x] tests added / passed
• [ x] Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[simonjayhawkins]

Thanks @alexprincel for the PR.

[lithomas1]

Can you add a note in the whatsnew?(doc/source/whatsnew/v1.3.0.rst, I think this should go under Other in the section bug fixes.)

[jreback]

pls also add a whatsnew note. bug fixes in I/O sectoin are ok

[pep8speaks]

Hello @alexprincel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-22 18:00:28 UTC

[alexprincel]

Not sure if this needs commenting (again, first-timer), but I believe I have implemented all requested changes and made testing more robust.

[lithomas1]

@alexprincel Looking at the diff, it looks like a merge went wrong somewhere. Can you fix this up?

[alexprincel]

@alexprincel Looking at the diff, it looks like a merge went wrong somewhere. Can you fix this up?

Sorry about that. What seems to be the problem? I will do my best to resolve it. My git skills are not yet up to par.

[lithomas1]

@alexprincel If you click on Files changed, you can see that there are unrelated changes in the pandas/tests/io directory. (Which I suspect is the result of a bad merge) I'm not really an expert on git either, so maybe you can ask one of the other maintainers for help.(If necessary you can revert the changes manually). Apart from the unrelated changes, LGTM.

[alexprincel]

@alexprincel If you click on Files changed, you can see that there are unrelated changes in the pandas/tests/io directory. (Which I suspect is the result of a bad merge) I'm not really an expert on git either, so maybe you can ask one of the other maintainers for help.(If necessary you can revert the changes manually). Apart from the unrelated changes, LGTM.

I saw this as well after. I have been reading on git this week and trying some things on test repos just to understand exactly what I need to do to correct this. If I can't figure it out I'll just start a new branch, put the modified files in that branch's working directory and commit that.

[MarcoGorelli]

If you only need to revert a handful of files, I'd suggest

git remote -v  # check that `upstream` is pandas-dev/pandas and `origin` is alexprincel/pandas
git fetch upstream master
git checkout upstream/master -- pandas/tests/io
git commit -m 'revert unrelated changes'
git push origin alexdev

[MarcoGorelli]

Thanks @alexprincel for updating - I think this almost ready, just a couple of minor comments

[alexprincel]

Thanks @alexprincel for updating - I think this almost ready, just a couple of minor comments

Will make them later today. Thanks for your comments, helps me improve.

[alexprincel]

I have addressed all comments. Thanks !

[MarcoGorelli]

Thanks @alexprincel - just one unused function to remove, other than that this looks good to me

[MarcoGorelli]

Pending green, this looks good to me

@simonjayhawkins any further comments, or good to merge?

[simonjayhawkins]

LGTM

[MarcoGorelli]

cool - merging then, as commit 02e6bc7 was green and the commit following that just changed a comment

Thank you @alexprincel !

[alexprincel]

cool - merging then, as commit 02e6bc7 was green and the commit following that just changed a comment

Thank you @alexprincel !

Thank you for your patience on this! Hopefully I will be more efficient on my next PR.