Skip to content

DOC: Ban mutation in UDF methods #39762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Feb 12, 2021

  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Ref: #12653. I added the message to apply, aggregate, transform, and groupby's filter. Not sure if this needs a whatsnew.

cc @jbrockmendel

@rhshadrach rhshadrach added Apply Apply, Aggregate, Transform, Map Docs labels Feb 12, 2021
return s

df = pd.DataFrame({"a": [1, 2, 3], 'b': [4, 5, 6]})
df.apply(f, axis="columns")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a complete-ish list of affected methods? probably agg, groupby.apply, groupby.agg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - I think you're suggesting to add a list to the gotchas doc. That sounds like a good idea - will do.

@jreback jreback added this to the 1.3 milestone Feb 15, 2021
@jreback jreback merged commit 7c2ff10 into pandas-dev:master Feb 15, 2021
@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

thanks @rhshadrach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants