Skip to content

DOC: added more and updated links in cheat sheet #39748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2021

Conversation

OliEfr
Copy link
Contributor

@OliEfr OliEfr commented Feb 11, 2021

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Docs label Feb 11, 2021
@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

can you say what you changed here.

cc @Dr-Irv

@jreback jreback added this to the 1.3 milestone Feb 11, 2021
@OliEfr
Copy link
Contributor Author

OliEfr commented Feb 11, 2021

I created this PR #39707 (which was essentially the same) and it was merged yesterday with master. However, I checked in pandas-dev:master and my changes don't appear there. The changes in the cheat sheet should look like this.

That is why I created another this PR which is essentially the same.

(I used to use a pullBot to stay up to date with master. I figured, that my changes might have been reversed by the pullbot?! Now I am not using a pullbot anymore.)

This is my first contribution to a larger OSS-Project and I am kind of confused by the automated tests. I am not sure how to fix the failing tests. Merging with master didn't help.

Sorry for confusion.

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Feb 11, 2021

@jreback He added hyperlinks to the documentation from the cheat sheet. I compared the current and his changes, and it looks fine to me. Nice idea. I merged it in.

Thanks @OliEfr

@Dr-Irv Dr-Irv merged commit a85b3b3 into pandas-dev:master Feb 11, 2021
@OliEfr
Copy link
Contributor Author

OliEfr commented Feb 11, 2021

Oh, thanks very much :) Happy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants