SAS validate null dates #39726
Merged
SAS validate null dates #39726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wertha
commented
Feb 10, 2021
•
wertha
commented
- closes BUG: SAS datetime column with null values cannot be parsed. #39725
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Feb 11, 2021
|
cc @bashtage |
wertha
force-pushed
the
sas_null_dates
branch
3 times, most recently
from
26ff9b3 to
4c0181e
Compare
bashtage
reviewed
Feb 11, 2021
|
It looks good aside from my personal preference over multi-line lambda functions which are really hard to read. |
wertha
force-pushed
the
sas_null_dates
branch
2 times, most recently
from
51b54ae to
8c4309c
Compare
attack68
reviewed
Feb 12, 2021
pandas/io/sas/sas7bdat.py
Outdated
| s_series = sas_datetimes.apply( | ||
| lambda sas_float: datetime(1960, 1, 1) + timedelta(seconds=sas_float) | ||
| ) | ||
| if unit in ["s", "d"]: |
There was a problem hiding this comment.
wondering if its better to move the arg check, and raise into the _parse_datetime() function?
There was a problem hiding this comment.
yes, makes sense, that way we don't double check. Will do
wertha
force-pushed
the
sas_null_dates
branch
from
8c4309c to
6aa6f64
Compare
jreback
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.