Skip to content

DOC: Rewrite for Styler user guide with new features and other high-level changes. #39720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Mar 29, 2021
Merged

DOC: Rewrite for Styler user guide with new features and other high-level changes. #39720

merged 59 commits into from
Mar 29, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Feb 10, 2021 •
edited
Loading

This renames Styling with Table Visualization and aligns it more with Chart Visualization.

It re-organises some of the Styler user guide, removing outdated material, including new material with examples.

attack68 added 30 commits January 21, 2021 12:59
@attack68
bug: cell ids included classes
a169f64 
bug: set_td_classes loop ignored entries
bug: tooltips indexing was dropped
doc: added documentation for methods
@attack68
add tests
847ec69
@attack68
doc fixes
e436a95
@attack68
Styler.apply permits ndarray with axis=None
4879094
@attack68
apply with row
1aa097e
@attack68
doc updates
228f619
@attack68
merge master
da3b454
@attack68
tests
259ca04
@attack68
whats new
ea6ad92
@attack68
op
09d6302
@attack68
doc fix
b9715c9
@attack68
text fix
c6173b5
@attack68
Merge remote-tracking branch 'upstream/master' into styler_apply
f1571a8
@attack68
Merge remote-tracking branch 'upstream/master' into styler_apply
1395b65 
# Conflicts:
#	doc/source/whatsnew/v1.3.0.rst
@attack68
renaming sections
212e14d
@attack68
Merge remote-tracking branch 'upstream/master' into styler_apply
6657841
@attack68
Merge remote-tracking branch 'upstream/master' into styler_apply
dc4114a
@attack68
Merge remote-tracking branch 'upstream/master' into docs
1656958
@attack68
Merge remote-tracking branch 'upstream/master' into docs
7340ed0
@attack68
doc changes
8a66438
@attack68
Merge remote-tracking branch 'upstream/master' into docs
2ddf5ad 
# Conflicts:
#	doc/source/user_guide/style.ipynb
@attack68
doc changes
c4e28fe
@attack68
cln: reorganise vars
8923dd9
@attack68
Merge remote-tracking branch 'upstream/master' into clean_structure
b73f0cc
@attack68
Merge remote-tracking branch 'upstream/master' into styler_apply
25e74fb 
# Conflicts:
#	doc/source/whatsnew/v1.3.0.rst
@attack68
docs
a463a53
@attack68
Merge remote-tracking branch 'origin/clean_structure' into docs
6f6352b
@attack68
Merge remote-tracking branch 'origin/styler_apply' into docs
26eaa85
@attack68
Merge remote-tracking branch 'upstream/master' into docs
a918ba0
@attack68
Merge remote-tracking branch 'origin/docs' into docs
95b8403 
# Conflicts:
#	doc/source/user_guide/style.ipynb
jreback pushed a commit that referenced this pull request Mar 20, 2021
@attack68
DOC: Styler docs - split PR from #39720 (#40493)
fd9354a
@attack68 attack68 changed the title [WIP] DOC: Rewrite for Styler user guide with new features and other high-level changes. DOC: Rewrite for Styler user guide with new features and other high-level changes. Mar 21, 2021
@jreback
Copy link
Contributor

jreback commented Mar 21, 2021

can you show a rendered view

@attack68
Copy link
Contributor Author

can you show a rendered view

I've zipped the HTML above, (just the one page - user guide). I couldn't publish an image here since the page is too long.

@attack68
Copy link
Contributor Author

@jreback this addresses only PRs that have been merged. I won't add anything further to it (except suggested changes),

For any other PRs that go into 1.3 I will submit a smaller change to the user guide afterwards just addressing those.

@attack68 attack68 mentioned this pull request Mar 26, 2021
Closed
rhshadrach
rhshadrach requested changes Mar 27, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks really great. Requests below are mostly grammar nit-picks, some more opinionated than others. Push back if you disagree on any.

@attack68
Copy link
Contributor Author

Latest render:
Archive.zip

@attack68
Copy link
Contributor Author

Thanks! This looks really great. Requests below are mostly grammar nit-picks, some more opinionated than others. Push back if you disagree on any.

thanks @rhshadrach for going over it in such detail! I noticed a few of these myself previously but needed a prod to actually implement the fixes!

rhshadrach
rhshadrach approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - cc @jreback.

@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

hmm some ci / checks are failing.

@attack68
Copy link
Contributor Author

hmm some ci / checks are failing.

@jreback these seem unrelated. I will merge and push

@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

hmm some ci / checks are failing.

@jreback these seem unrelated. I will merge and push

right yeah this was the first one i looked :-<, yep they are unrealted ok. ping on greenish.

@attack68
Copy link
Contributor Author

@jreback this is green-ish, green-er than before now anyway.

@jreback jreback merged commit dd697e1 into pandas-dev:master Mar 29, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

thanks @attack68 pls check the built docs after they are built

@attack68 attack68 deleted the docs branch March 29, 2021 17:00
@attack68
Copy link
Contributor Author

thanks @attack68 pls check the built docs after they are built

will do.

@moi90 moi90 mentioned this pull request Mar 30, 2021
Closed
4 tasks
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@attack68 @vladu
DOC: Rewrite for Styler user guide with new features and other high…
131c5d8 
…-level changes. (pandas-dev#39720)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@attack68 @JulianWgs
DOC: Styler docs - split PR from pandas-dev#39720 (pandas-dev#40493)
d3f9207
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@attack68 @JulianWgs
DOC: Rewrite for Styler user guide with new features and other high…
2f5a795 
…-level changes. (pandas-dev#39720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Docs Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
1.3
4 participants
@attack68 @pep8speaks @jreback @rhshadrach