Skip to content

DOC: Group optional dependencies by category #39715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

nmay231
Copy link
Contributor

@nmay231 nmay231 commented Feb 10, 2021

This PR splits the Optional Dependencies table into multiple tables one for each category. It should help people compare different options when looking for a specific capability, e.g. "I need to read an Excel file. What are my options?".

The specific grouping felt pretty subjective. If you think of a better way to group them, we can do that instead.

@jreback
Copy link
Contributor

jreback commented Feb 10, 2021

looks fine. can you post a rendered screenshot?

@jreback jreback added the Docs label Feb 10, 2021
@jreback jreback added this to the 1.3 milestone Feb 10, 2021
@nmay231
Copy link
Contributor Author

nmay231 commented Feb 10, 2021

@jreback

Here's a pastebin of the full html page. And here's a couple screenshots.

1
2
3

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
I added two small suggestions

@jreback
Copy link
Contributor

jreback commented Feb 10, 2021

@nmay231 thanks, yeah looks good. ping after @jorisvandenbossche suggestions are pushed & green.

@nmay231
Copy link
Contributor Author

nmay231 commented Feb 11, 2021

@jorisvandenbossche

@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

can you merge master

@nmay231
Copy link
Contributor Author

nmay231 commented Feb 16, 2021

@jreback Merged with master

@nmay231
Copy link
Contributor Author

nmay231 commented Feb 17, 2021

@jreback Updated

@nmay231
Copy link
Contributor Author

nmay231 commented Feb 22, 2021

@jreback Sorry for the misunderstanding. It's fixed now.

@jreback jreback merged commit 3de476a into pandas-dev:master Feb 22, 2021
@jreback
Copy link
Contributor

jreback commented Feb 22, 2021

thanks @nmay231 very nice.

https://pandas.pydata.org/pandas-docs/dev/ will have the built docs (once CI is done), check that everything renders properly.

thanks!

@nmay231 nmay231 deleted the doc-nmay branch February 22, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Group optional dependencies by relevant topic
3 participants