Skip to content

REF: implement ensure_can_hold_na #39714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2021
Merged

REF: implement ensure_can_hold_na #39714

merged 5 commits into from
Feb 10, 2021

Conversation

jbrockmendel
Copy link
Member

Much simpler than maybe_promote, which for the most part id like to replace with something like

def maybe_promote(dtype, fill_value):
    inferred, fv = infer_dtype_from(fill_value)
    new_dtype = find_common_type([dtype, inferred])
    return inferred, fv

@jreback jreback added Refactor Internal refactoring of code Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 10, 2021
@jreback jreback added this to the 1.3 milestone Feb 10, 2021
@jreback
Copy link
Contributor

jreback commented Feb 10, 2021

sure can you rebase

@jreback jreback merged commit 38f701e into pandas-dev:master Feb 10, 2021
@jbrockmendel jbrockmendel deleted the ref-ensure_can_hold_na branch February 10, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback