Skip to content

CLN: remove unused arg from Index._get_unique_index #39689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2620,36 +2620,15 @@ def duplicated(self, keep="first"):
return np.zeros(len(self), dtype=bool)
return super().duplicated(keep=keep)

def _get_unique_index(self, dropna: bool = False):
def _get_unique_index(self: _IndexT) -> _IndexT:
"""
Returns an index containing unique values.

Parameters
----------
dropna : bool, default False
If True, NaN values are dropped.

Returns
-------
uniques : index
Index
"""
if self.is_unique and not dropna:
return self

if not self.is_unique:
values = self.unique()
if not isinstance(self, ABCMultiIndex):
# extract an array to pass to _shallow_copy
values = values._data
else:
values = self._values

if dropna and not isinstance(self, ABCMultiIndex):
# isna not defined for MultiIndex
if self.hasnans:
values = values[~isna(values)]

return self._shallow_copy(values)
return self.unique()

# --------------------------------------------------------------------
# Arithmetic & Logical Methods
Expand Down
6 changes: 2 additions & 4 deletions pandas/core/indexes/extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,11 @@ def insert(self, loc: int, item):
# ExtensionIndex subclasses must override Index.insert
raise AbstractMethodError(self)

def _get_unique_index(self, dropna=False):
if self.is_unique and not dropna:
def _get_unique_index(self):
if self.is_unique:
return self

result = self._data.unique()
if dropna and self.hasnans:
result = result[~result.isna()]
return self._shallow_copy(result)

@doc(Index.map)
Expand Down
5 changes: 2 additions & 3 deletions pandas/tests/indexes/multi/test_duplicates.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,11 @@ def test_unique_level(idx, level):
tm.assert_index_equal(result, expected)


@pytest.mark.parametrize("dropna", [True, False])
def test_get_unique_index(idx, dropna):
def test_get_unique_index(idx):
mi = idx[[0, 1, 0, 1, 1, 0, 0]]
expected = mi._shallow_copy(mi[[0, 1]])

result = mi._get_unique_index(dropna=dropna)
result = mi._get_unique_index()
assert result.unique
tm.assert_index_equal(result, expected)

Expand Down
13 changes: 6 additions & 7 deletions pandas/tests/indexes/test_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,8 @@ def test_get_unique_index(self, index_flat):
except NotImplementedError:
pass

for dropna in [False, True]:
result = idx._get_unique_index(dropna=dropna)
tm.assert_index_equal(result, idx_unique)
result = idx._get_unique_index()
tm.assert_index_equal(result, idx_unique)

# nans:
if not index._can_hold_na:
Expand Down Expand Up @@ -188,10 +187,10 @@ def test_get_unique_index(self, index_flat):
assert idx_nan.dtype == index.dtype
assert idx_unique_nan.dtype == index.dtype

for dropna, expected in zip([False, True], [idx_unique_nan, idx_unique]):
for i in [idx_nan, idx_unique_nan]:
result = i._get_unique_index(dropna=dropna)
tm.assert_index_equal(result, expected)
expected = idx_unique_nan
for i in [idx_nan, idx_unique_nan]:
result = i._get_unique_index()
tm.assert_index_equal(result, expected)

def test_searchsorted_monotonic(self, index_flat):
# GH17271
Expand Down