Skip to content

CI: run database tests only #39550 #39666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 19, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Feb 8, 2021

@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

hmm maybe its the db - cov build that is a problem. i guess any way to split up these cov builds? (this might be harder, as now we would have multiple uploads to code-cov, but also maybe unavoidable)

@jreback jreback added the CI Continuous Integration label Feb 8, 2021
@fangchenli
Copy link
Member Author

hmm maybe its the db - cov build that is a problem. i guess any way to split up these cov builds? (this might be harder, as now we would have multiple uploads to code-cov, but also maybe unavoidable)

https://docs.codecov.io/docs/merging-reports Codecov automatically merges multiple reports. So we don't even need a separate build for coverage. We could select a set of builds that include all tests, run coverage, and upload reports for all of them.

@jreback
Copy link
Contributor

jreback commented Feb 9, 2021

hmm maybe its the db - cov build that is a problem. i guess any way to split up these cov builds? (this might be harder, as now we would have multiple uploads to code-cov, but also maybe unavoidable)

https://docs.codecov.io/docs/merging-reports Codecov automatically merges multiple reports. So we don't even need a separate build for coverage. We could select a set of builds that include all tests, run coverage, and upload reports for all of them.

that would be great! (but should tag the builds as -cov just to indicate that they are part of the coverage build(s))

@fangchenli
Copy link
Member Author

I probably won't have time to work on the coverage stuff in the next couple of days. I opened #39758. So people can take from there.

@fangchenli fangchenli closed this Feb 11, 2021
@fangchenli fangchenli reopened this Mar 18, 2021
@fangchenli fangchenli changed the title run database tests only #39550 CI: run database tests only #39550 Mar 18, 2021
shell: bash -l {0}
strategy:
matrix:
ENV_FILE: [ci/deps/actions-37-locale.yaml, ci/deps/actions-37-cov.yaml]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fangchenli - in #39758 you wrote

and remove the actions-37-cov build if it's no longer required.

but here it looks like you're keeping it - is it still required then?

Copy link
Member Author

@fangchenli fangchenli Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the db builds is testing the minimum support versions of SQL-related packages. So I think it's better to keep both of them. But should rename them to reflect their actual purpose.

@jreback jreback added this to the 1.3 milestone Mar 19, 2021
@jreback jreback merged commit 2b9ad6f into pandas-dev:master Mar 19, 2021
@jreback
Copy link
Contributor

jreback commented Mar 19, 2021

thanks @fangchenli very nice

@fangchenli fangchenli deleted the run-database-only branch March 21, 2021 03:45
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
3 participants