-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: run database tests only #39550 #39666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fangchenli
commented
Feb 8, 2021
•
edited
Loading
edited
- closes CI: have database builds *just* run db tests #39550
- closes CI: remove the current coverage build, run coverage on multiple builds instead #39758
hmm maybe its the db - cov build that is a problem. i guess any way to split up these cov builds? (this might be harder, as now we would have multiple uploads to code-cov, but also maybe unavoidable) |
https://docs.codecov.io/docs/merging-reports Codecov automatically merges multiple reports. So we don't even need a separate build for coverage. We could select a set of builds that include all tests, run coverage, and upload reports for all of them. |
that would be great! (but should tag the builds as -cov just to indicate that they are part of the coverage build(s)) |
I probably won't have time to work on the coverage stuff in the next couple of days. I opened #39758. So people can take from there. |
.github/workflows/database.yml
Outdated
shell: bash -l {0} | ||
strategy: | ||
matrix: | ||
ENV_FILE: [ci/deps/actions-37-locale.yaml, ci/deps/actions-37-cov.yaml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fangchenli - in #39758 you wrote
and remove the actions-37-cov build if it's no longer required.
but here it looks like you're keeping it - is it still required then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the db builds is testing the minimum support versions of SQL-related packages. So I think it's better to keep both of them. But should rename them to reflect their actual purpose.
thanks @fangchenli very nice |