Enhancement dataframe to csv use zip method #39662
Conversation
There was a problem hiding this comment.
looks like this breaks some tests
=========================== short test summary info ============================
FAILED pandas/tests/io/formats/test_to_csv.py::TestToCSV::test_to_csv_zip_arguments[None-zip]
FAILED pandas/tests/io/formats/test_to_csv.py::TestToCSV::test_to_csv_zip_arguments[None-infer]
| @@ -726,6 +726,12 @@ def __init__( | |||
| self.archive_name = archive_name | |||
| self.multiple_write_buffer: Optional[Union[StringIO, BytesIO]] = None | |||
|
|
|||
| # add csv file name like gz or bz2 | |||
| if archive_name is None and isinstance(file, (os.PathLike, str)): | |||
| archive_name = os.path.basename(file) | |||
There was a problem hiding this comment.
probably better to replace os.path.basename with stringify_path (to handle PathLike objects). That might also fix the failing test_to_csv_compression_encoding_gcs test.
There was a problem hiding this comment.
its strange that this test passed on my win10 laptop.
There was a problem hiding this comment.
sorry, you probably still need basename to avoid having the entire path within the archive
There was a problem hiding this comment.
revert to os.path.basename , but start get different ci errors, does my commit affect it?
There was a problem hiding this comment.
Can you add a small test case. For example, write a compressed CSV file and then open it with zipfile.ZipFile to check the name.
There was a problem hiding this comment.
add test case and finish pre commit, a new PR is opened #40387
…rame_to_csv_use_zip_method
合并mainstream
… expected to be 'xxxx.cvs'
|
Hello @HQDragon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-03-11 07:51:12 UTC |
… expected to be 'xxxx.cvs'
…_zip_method' into enhancement_dataframe_to_csv_use_zip_method # Conflicts: # pandas/tests/frame/methods/test_to_csv.py
… expected to be 'xxxx.cvs'
…_zip_method' into enhancement_dataframe_to_csv_use_zip_method # Conflicts: # pandas/tests/frame/methods/test_to_csv.py
Enhancement dataframe to csv use zip method,now df.to_csv('myfile.csv.zip') works like df.to_csv('myfile.csv.gz'), generate a zip file with a myfile.csv as content
test code