Skip to content

ENH add cython tutorial #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2013
Merged

ENH add cython tutorial #3965

merged 3 commits into from
Jun 21, 2013

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Jun 19, 2013

WIP #3923

Please checkout this draft for a pandas cython tutorial, any feedback or ideas appreciated.

Thanks to @cpcloud for patiently working out/explaining how to force ipython sphinx directive to play nicely with %%cython (it's incredibly sensitive!) and fixing the spacing bug. This seems to build now. :)

@jreback
Copy link
Contributor

jreback commented Jun 19, 2013

I think you need to add this file to index.rst to get it 2 show up

@jtratner
Copy link
Contributor

I'm looking forward to reading it. Do you think you could write up a guide
to caching builds next? (I'm not clear whether the issue or PR you linked
is up to date.) I tried to do it and I don't think I did it right :P
On Jun 19, 2013 7:28 PM, "Andy Hayden" [email protected] wrote:

WIP #3923 #3923

Please checkout this draft for a pandas cython tutorial, any feedback or
ideas appreciated.

*Thanks to @cpcloud https://github.com/cpcloud for the working out how
to force ipython sphinx directive to play nicely with %%cython (it's

incredibly sensitive!) and fixing the spacing bug. This seems to build.*

You can merge this Pull Request by running

git pull https://github.com/hayd/pandas cython_doc

Or view, comment on, or merge it at:

#3965
Commit Summary

  • ENH add cython tutorial

File Changes

Patch Links:

@hayd
Copy link
Contributor Author

hayd commented Jun 20, 2013

@jtratner this pr is the upto date one, it should build, but @jreback is right i hadn't added it to the index (but the file was created here: doc/build/html/cython.html ). I've added it in now.

@cpcloud
Copy link
Member

cpcloud commented Jun 20, 2013

@y-p probably knows the most about caching builds since he's the one who added that functionality iirc. i'll try to help in the meantime...when u cache a build setup.py gets rewritten. i always do a git checkout setup.py afterward to restore to the original state. the thing u should notice is that the second time after running tox u should get a nice speedup.

@ghost
Copy link

ghost commented Jun 20, 2013

#3156 describes the use of the build cache (I cleaned it up slightly last night).
The shell alias provided there is what I use myself, it also restores
the files it modifies.
If there's a problem with the build cache, open an issue and i'll take a look.

@@ -131,5 +131,6 @@ See the package overview for more detail about what's in the library.
r_interface
related
comparison_with_r
cython
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you should put this after sparse (up a couple)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure (as "Enhancing Performance").

@jreback
Copy link
Contributor

jreback commented Jun 20, 2013

mergable?

@cpcloud
Copy link
Member

cpcloud commented Jun 20, 2013

@hayd btw pasting cell magics works in ipython master may want to note this and if you're crazy gung ho u can do a bisect and find out which change introduced this feature and point users the version that allows them to paste, but that's probably a bit overkill

@hayd
Copy link
Contributor Author

hayd commented Jun 20, 2013

@jreback let me just make the change to Enhancing Performance (when I get home in an hour or so). It's not weird to have cython as the only section...?

@cpcloud ah, that's strange, I thought I'd convinced myself pasting did work in my version, will check it out the ipython issues and see if I can locate change. Or maybe I'll say something vague, definitely worth mentioning.

Actually... there is a lot of TODO's in there, was hoping for some feedback on those bits :)

change name to Enhancing performance
add in some sections
@hayd
Copy link
Contributor Author

hayd commented Jun 20, 2013

@jreback think it could be good to merge (with a once over)

I've added sections and (recklessly) removed all the todos....

@jreback
Copy link
Contributor

jreback commented Jun 21, 2013

@hayd I think ok to merge....

I like to look at them on web for real...then fix things I find!

@hayd
Copy link
Contributor Author

hayd commented Jun 21, 2013

let's do it then

hayd added a commit that referenced this pull request Jun 21, 2013
@hayd hayd merged commit 3aafd6a into pandas-dev:master Jun 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants