API: transform behaves differently with 'ffill' on DataFrameGroupBy and SeriesGroupBy #39638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ftrihardjo
commented
Feb 7, 2021
•
ftrihardjo
commented
- closes transform behaves differently with 'ffill' on DataFrameGroupBy and SeriesGroupBy #24211
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Thanks @ftrihardjo - could you make the title the same as the issue please, and put the issue number in the pull request body (near |
jreback
changed the title
jreback
added
Missing-data
jreback
requested changes
Feb 7, 2021
| data = [["a", 0.0], ["a", float("nan")], ["b", 1.0], ["b", float("nan")]] | ||
| df = DataFrame(data, columns=["key", "values"]) | ||
| tm.assert_series_equal( | ||
| df.groupby("key").transform("ffill")["values"], |
There was a problem hiding this comment.
can you use
result=
expected=
| df.groupby("key").transform("ffill")["values"], | ||
| df.groupby("key")["values"].transform("ffill"), | ||
| ) | ||
|
|
There was a problem hiding this comment.
test both for seriesgropuby & dataframegroupby
| @@ -938,6 +938,16 @@ def test_any_all_np_func(func): | |||
| tm.assert_series_equal(res, exp) | |||
|
|
|||
|
|
|||
| def test_transform_ffill(): | |||
| # GH 24211 | |||
| data = [["a", 0.0], ["a", float("nan")], ["b", 1.0], ["b", float("nan")]] | |||
There was a problem hiding this comment.
can you co-locate with other ffill/filling tests (in this file)
MarcoGorelli
approved these changes
Feb 14, 2021
jreback
approved these changes
Feb 15, 2021
|
thanks @ftrihardjo |
znicholls
pushed a commit
to znicholls/pandas
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.