Skip to content

CLN: Use kwargs instead of kwds in apply functions #39625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

I've applied the change here to the API function apply but I don't believe this is an API change as you cannot pass to **kwds (or **kwargs) by name.

@rhshadrach rhshadrach added Clean Apply Apply, Aggregate, Transform, Map labels Feb 6, 2021
@jreback jreback modified the milestones: 1.2.3, 1.3 Feb 7, 2021
@jreback jreback merged commit 545cbbf into pandas-dev:master Feb 7, 2021
@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

thanks yep, this is not user facing. we could have a rule for this to prevent recurrences (but prob no big deal)

@rhshadrach rhshadrach deleted the apply_kwargs branch February 7, 2021 16:43
CyberQin pushed a commit to CyberQin/pandas that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants