BUG: Series[int].__setitem__(mask, td64_or_dt64) incorrect casting #39619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Feb 5, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
approved these changes
Feb 7, 2021
| # https://github.com/numpy/numpy/issues/12550 | ||
| # timedelta64 will incorrectly cast to int | ||
| converted = [converted] * mask.sum() | ||
| values[mask] = converted | ||
| if not is_list_like(converted): |
There was a problem hiding this comment.
this pattern is pretty common, maybe a helper function?
There was a problem hiding this comment.
yah one more PR coming up that uses this pattern yet again; i think its going to end up in array_algos.putmask,
| # expressions.where will cast np.timedelta64 to int | ||
| result = self.values.copy() | ||
| result[~cond] = [other] * (~cond).sum() | ||
| dtype, _ = infer_dtype_from(other, pandas_dtype=True) |
jreback
added
the
Indexing
CyberQin
pushed a commit
to CyberQin/pandas
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.