REGR: Rolling.count setting min_periods after call #39604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Feb 5, 2021
mroeschke
commented
- closes BUG: Rolling.count modifies 'min_periods' inplace since 1.2.0 #39554
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
added
Window
jreback
requested changes
Feb 5, 2021
| @@ -1437,7 +1437,11 @@ def count(self): | |||
| FutureWarning, | |||
| ) | |||
| self.min_periods = 0 | |||
| return super().count() | |||
| result = super().count() | |||
There was a problem hiding this comment.
grr this is not pretty. maybe have a _count() method where you can pass min_periods? (for 1.2.2 this is prob ok, but for 1.3)
There was a problem hiding this comment.
Hmm either is a shim that will be removed in 2.0. I think in either way I'll have to do this gymnastics since min_periods is set globally on the object
There was a problem hiding this comment.
ok for here, I was talking about a _count() (private method) that we could pass thru min_periods
jreback
approved these changes
Feb 5, 2021
|
@meeseeksdev backport 1.2.x |
|
thanks @mroeschke |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Feb 7, 2021
simonjayhawkins
added a commit
that referenced
this pull request
Feb 7, 2021
#39634) Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.