Skip to content

Added an example for infer_freq #39558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Added an example for infer_freq #39558

merged 3 commits into from
Mar 30, 2021

Conversation

Remit
Copy link
Contributor

@Remit Remit commented Feb 2, 2021

Added an example for infer_freq function. The initial index is built using a fixed number of periods to avoid encoding frequency in this index explicitly.

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2021

Hello @Remit! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-30 18:15:00 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 5, 2021
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this PR slip through the cracks. Just one comment otherwise LGTM


Examples
--------
>>> idx = pd.date_range(start = '2020/12/01', end = '2020/12/30', periods = 30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you eliminate the spaces between the = e.g start = '2020/12/01'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke done. I'm kinda newb to submitting my changes in public repos so I hope that I managed to do it correctly :)

@mroeschke mroeschke removed the Stale label Mar 29, 2021
@mroeschke
Copy link
Member

Also this PR should target the master branch instead

@jreback jreback added Docs Frequency DateOffsets labels Mar 29, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

let's close this in a couple of days if no response

@mroeschke mroeschke changed the base branch from 1.2.x to master March 29, 2021 18:33
@mroeschke
Copy link
Member

@Remit I changed the target branch to master, but it will require you to rebase with master

Remit added 3 commits March 30, 2021 20:14
Added an example for infer_freq function. The initial index is built using a fixed number of periods to avoid encoding frequency in this index explicitly.
Removed empty line and deleted spaces.
@Remit
Copy link
Contributor Author

Remit commented Mar 30, 2021

@Remit I changed the target branch to master, but it will require you to rebase with master

@mroeschke thanks! I did the rebase, but it seems like some checks fail for the current build. Does not look to be connected with my commit

@jreback jreback added this to the 1.3 milestone Mar 30, 2021
@jreback jreback merged commit cc63476 into pandas-dev:master Mar 30, 2021
@jreback
Copy link
Contributor

jreback commented Mar 30, 2021

thanks @Remit

the failures on default are known

@Remit
Copy link
Contributor Author

Remit commented Mar 31, 2021

thanks @Remit

the failures on default are known

thanks Jeff! Got it.

vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants