Skip to content

DOC: add example to insert (#39313) #39500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2021
Merged

DOC: add example to insert (#39313) #39500

merged 3 commits into from
Feb 1, 2021
+8 −0

Conversation

nofarm3
Copy link
Contributor

@nofarm3 nofarm3 commented Jan 31, 2021 •
edited
Loading

@MarcoGorelli MarcoGorelli self-requested a review January 31, 2021 15:22
@MarcoGorelli
Copy link
Member

Thanks @nofarm3 - the example looks good, but I get a couple of warnings when trying to build it locally (python make.py --single pandas.DataFrame.insert):

reading sources... [100%] reference/api/pandas.DataFrame.insert                                                                                                                                           
/home/marco/pandas-marco/pandas/core/frame.py:docstring of pandas.core.frame.DataFrame.insert:58: WARNING: Unexpected indentation.
/home/marco/pandas-marco/pandas/core/frame.py:docstring of pandas.core.frame.DataFrame.insert:59: WARNING: Block quote ends without a blank line; unexpected unindent.

@nofarm3
Copy link
Contributor Author

nofarm3 commented Jan 31, 2021

@MarcoGorelli Thanks Marco, fixed.
I think the current failures are not related to my change.

MarcoGorelli
MarcoGorelli approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nofarm3 !

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Feb 1, 2021
MarcoGorelli
MarcoGorelli reviewed Feb 1, 2021
View reviewed changes
@MarcoGorelli MarcoGorelli merged commit 3dfbf49 into pandas-dev:master Feb 1, 2021
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 1, 2021
Closed
@nofarm3 nofarm3 deleted the add-examples-to-insert branch February 2, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DOC: add examples to DataFrame.insert()
3 participants
@nofarm3 @MarcoGorelli @nofarmish