BUG: cumulative functions with ea dtype not handling NA correctly and casting to object #39483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Jan 30, 2021
phofl
commented
- closes BUG: cumsum() shows inconsistent results in nullable dtype #39479
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
… casting to object
jreback
requested changes
Jan 30, 2021
pandas/core/nanops.py
Outdated
| @@ -1728,12 +1731,27 @@ def na_accum_func(values: ArrayLike, accum_func, *, skipna: bool) -> ArrayLike: | |||
| result, dtype=orig_dtype | |||
| ) | |||
|
|
|||
| elif skipna and not issubclass(values.dtype.type, (np.integer, np.bool_)): | |||
| elif ( | |||
There was a problem hiding this comment.
i think maybe ok to have is_ea_dtype be a separate elif; much easier to rationalize here
|
More general solution is being worked on in #28509 (which doesn't mean a short term solution can't be merged, I didn't closely look at either PR, just noting) |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
| vals[mask] = mask_a | ||
| result = accum_func(vals, axis=0) | ||
| result[mask_copy] = mask_b | ||
| result = sanitize_array(result, None, values.dtype) |
There was a problem hiding this comment.
sanitize_array is relatively heavy-weight. what cases is it handling?
|
@phofl closing as stale. #39483 (comment) needs addressing. reopen when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.