-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ERR: Unify error message for bad excel sheetnames #39482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine. no objection to backporting to 1.2.2 (move the note)
Thanks @jreback, note moved to 1.2.2. bugfixes |
thanks @rhshadrach |
@meeseeksdev backport 1.2.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
@rhshadrach can you follow the instructions and backport this |
…#39536) Co-authored-by: Richard Shadrach <[email protected]>
IMO the core issue in #39250 is upstream in openpyxl, providing a better error message is really tangential to it. Since the error message that openpyxl raises is not a regression, it seemed best to me to (a) target this for 1.3 and (b) unify all error messages across engines.
If, on the other hand, we really do want to improve the error message in 1.2.2 because of the switch from xlrd to openpyxl, then I will open a new PR for 1.2.2 that only impacts openpyxl.
Will do a followup to remove the duplicate tests.
cc @simonjayhawkins @jorisvandenbossche