Skip to content

BUG: Series[bool].__setitem__(scalar, non_bool) #39478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 2, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@@ -1910,6 +1910,9 @@ def validate_numeric_casting(dtype: np.dtype, value: Scalar) -> None:
raise ValueError(
f"Cannot assign {type(value).__name__} to float/integer series"
)
if dtype.kind == "b":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves labels Jan 30, 2021
@jreback jreback added this to the 1.3 milestone Jan 30, 2021
@jreback jreback merged commit aa97540 into pandas-dev:master Feb 2, 2021
@jbrockmendel jbrockmendel deleted the bug-series-setitem branch February 2, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants