Skip to content

BUG: Assert_frame_equal always raising AssertionError when comparing extension dtypes #39423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 26, 2021

@phofl phofl added Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite labels Jan 26, 2021
@jbrockmendel
Copy link
Member

LGTM pending green

@jreback jreback added this to the 1.2.2 milestone Jan 28, 2021
@jreback jreback added the ExtensionArray Extending pandas with custom dtypes or arrays. label Jan 28, 2021
@jreback jreback merged commit 201d263 into pandas-dev:master Jan 28, 2021
@jreback
Copy link
Contributor

jreback commented Jan 28, 2021

thanks @phofl

@jreback
Copy link
Contributor

jreback commented Jan 28, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 28, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 201d263aefecabc84ee49add65f37d06b45966e9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #39423: BUG: Assert_frame_equal always raising AssertionError when comparing extension dtypes'
  1. Push to a named branch :
git push YOURFORK 1.2.x:auto-backport-of-pr-39423-on-1.2.x
  1. Create a PR against branch 1.2.x, I would have named this PR:

"Backport PR #39423 on branch 1.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Jan 28, 2021

cc @phofl if you wouldn't mind doing the backport here

@phofl
Copy link
Member Author

phofl commented Jan 28, 2021

Done

simonjayhawkins pushed a commit that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite
Projects
None yet
3 participants