BUG: Subset slicer on Styler failed on MultiIndex with slice(None) #39421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review.. |
# Conflicts: # doc/source/whatsnew/v1.3.0.rst
|
can you merge master |
|
cc @phofl @jbrockmendel if you'd have a look |
jbrockmendel
reviewed
Feb 3, 2021
pandas/core/indexing.py
Outdated
| part, tuple | ||
| ) | ||
| if isinstance(part, tuple): | ||
| # check for sub-slice: |
There was a problem hiding this comment.
can you add "GH#39421" here
instead of a for loop can you do this with an any(...)
# Conflicts: # doc/source/whatsnew/v1.3.0.rst
|
lgtm |
|
thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with above issue was with the function
non_reducing_slice. It didn't correctly re-format slicing tuples on multiindices when rows or cols also contained aslice(None). An additional check is now done. This method is only used forStylercurrently.Tests Added / reformmatted.