Skip to content

DOC: Update mypy version in whatsnew #39419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 26, 2021

  • whatsnew entry

Forgot this in #39407

@phofl phofl mentioned this pull request Jan 26, 2021
2 tasks
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl

@simonjayhawkins simonjayhawkins added Docs Typing type annotations, mypy/pyright type checking labels Jan 26, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jan 26, 2021
@phofl
Copy link
Member Author

phofl commented Jan 26, 2021

Is backporting here necessary? Meaning regression fixes which do not pass with old mypy?

@simonjayhawkins
Copy link
Member

Is backporting here necessary?

no we keep the style checks etc on the backport branch unchanged.

so ci on 1.2.x uses mypy 0.782 and we need to make changes to autobackports if they fail the ci.

@phofl
Copy link
Member Author

phofl commented Jan 26, 2021

Ah thanks for the info

@simonjayhawkins simonjayhawkins merged commit f164cb9 into pandas-dev:master Jan 26, 2021
@phofl phofl deleted the upd_mypy branch January 26, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants