BUG: make Index.where behavior mirror Index.putmask behavior #39412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 26, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Jan 28, 2021
| # coerces to object | ||
| return self.astype(object).putmask(mask, value) | ||
| dtype = self._find_common_type_compat(value) | ||
| return self.astype(dtype).putmask(mask, value) |
There was a problem hiding this comment.
we'll always be making a copy here since dtype != self.dtype
| @@ -799,29 +799,22 @@ def length(self): | |||
| return Index(self._data.length, copy=False) | |||
|
|
|||
| def putmask(self, mask, value): | |||
| arr = self._data.copy() | |||
| mask = np.asarray(mask, dtype=bool) | |||
There was a problem hiding this comment.
can't you share / use the array/interval putmask code here?
There was a problem hiding this comment.
we do; L814-815 is directly using IntervalArray.putmask. everything before that point is for ways that the Index method behaves differently from the array method
jreback
added
Dtype Conversions
|
needs a rebase. can you add a whatsnew on what is changing here |
|
one more rebase |
|
rebased + green |
|
can you merge master |
|
rebased + finally green |
jreback
approved these changes
Feb 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.