Skip to content

TST: tighten Decimal tests #39381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

TST: tighten Decimal tests #39381

merged 1 commit into from
Jan 25, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback reviewed Jan 25, 2021
View reviewed changes
pandas/tests/extension/decimal/test_decimal.py
vcs_ex = pd.Series(other).value_counts(dropna=dropna)

with decimal.localcontext() as ctx:
# avoid raising when comparing Decimal("NAN") < Decimal(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be handling this error inside the EA e.g. isn't this a reason that DecimalArray should define values_for_argsort?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until we have a general ExtensionIndex, values_for_argsort wont help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh because this is the index of value counts itself.

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 25, 2021
@jreback jreback added this to the 1.3 milestone Jan 25, 2021
@jreback jreback merged commit 7d9ad04 into pandas-dev:master Jan 25, 2021
@jbrockmendel jbrockmendel deleted the tst-decimal branch January 25, 2021 16:49
@BryanCutler BryanCutler mentioned this pull request Feb 9, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback