Skip to content

Fixed code breakage for return_type = tuples for axis = 0 #39375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rajat315315
Copy link

@pep8speaks
Copy link

pep8speaks commented Jan 24, 2021

Hello @rajat315315! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-25 06:30:45 UTC

@jreback jreback added this to the 1.3 milestone Jan 24, 2021
@jreback jreback added Testing pandas testing functions or related to the test suite Apply Apply, Aggregate, Transform, Map and removed Testing pandas testing functions or related to the test suite labels Jan 24, 2021
PEP error fixed

Modified previous commit
@MarcoGorelli
Copy link
Member

Are we sure this is the correct solution? Because in #35518 (comment) it was mentioned that even for list then we should get a Series of lists, while with the current changes we have

In [7]: pd.DataFrame([['orig1', 'orig2']]).apply(func=lambda col: ['new1', 'new2'])
Out[7]: 
      0     1
0  new1  new1
1  new2  new2

instead of

0    [new1, new2]
1    [new1, new2]
dtype: object

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 1, 2021
@MarcoGorelli
Copy link
Member

closing as stale (+ I don't think this is the solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas 1.0.5 → 1.1.0 behavior change on DataFrame.apply() where func returns tuple
4 participants