Skip to content

BUG: fix python3/2 numpy import_array macro build issue with clang #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2013
Merged

BUG: fix python3/2 numpy import_array macro build issue with clang #3936

merged 1 commit into from
Jun 17, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 17, 2013

closes #3872. no really, it does.

@jreback
Copy link
Contributor

jreback commented Jun 17, 2013

famous last words :)

@cpcloud
Copy link
Member Author

cpcloud commented Jun 17, 2013

i wish u could test different compilers on travis...

@cpcloud
Copy link
Member Author

cpcloud commented Jun 17, 2013

@rhstanton can u test this? or anyone with a fairly recent mac? i don't remember when they switched to clang

@rhstanton
Copy link
Contributor

Yup. Works for me using Anaconda on a very recent Mac.

From: Phillip Cloud <[email protected]mailto:[email protected]>
Reply-To: pydata/pandas <[email protected]mailto:[email protected]>
Date: Monday, June 17, 2013 1:02 PM
To: pydata/pandas <[email protected]mailto:[email protected]>
Cc: Richard Stanton <[email protected]mailto:[email protected]>
Subject: Re: [pandas] BUG: fix python3/2 numpy import_array macro build issue with clang (#3936)

@rhstantonhttps://github.com/rhstanton can u test this? or anyone with a fairly recent mac? i don't remember when they switched to clang


Reply to this email directly or view it on GitHubhttps://github.com//pull/3936#issuecomment-19570659.

cpcloud added a commit that referenced this pull request Jun 17, 2013
BUG: fix python3/2 numpy import_array macro build issue with clang
@cpcloud cpcloud merged commit 964516a into pandas-dev:master Jun 17, 2013
@cpcloud cpcloud deleted the json-fix-round-2 branch June 17, 2013 20:22
@cpcloud
Copy link
Member Author

cpcloud commented Jun 17, 2013

https://travis-ci.org/pydata/pandas/jobs/8174283

this is starting to get annoying...

@rhstanton
Copy link
Contributor

To annoy you even more, the latest version (as of 5 minutes ago) actually now compiles fine on my Mac. No idea why...

From: Phillip Cloud <[email protected]mailto:[email protected]>
Reply-To: pydata/pandas <[email protected]mailto:[email protected]>
Date: Monday, June 17, 2013 2:33 PM
To: pydata/pandas <[email protected]mailto:[email protected]>
Cc: Richard Stanton <[email protected]mailto:[email protected]>
Subject: Re: [pandas] BUG: fix python3/2 numpy import_array macro build issue with clang (#3936)

https://travis-ci.org/pydata/pandas/jobs/8174283

this is starting to get annoying...


Reply to this email directly or view it on GitHubhttps://github.com//pull/3936#issuecomment-19576454.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 17, 2013

that's cuz i just merged the fix :) the build didn't pass travis tho bc of these google network error tests. i keep getting these intermittently and it's annoying. not sure why tho i think @gliptak is working on it.

@gliptak
Copy link
Contributor

gliptak commented Jun 18, 2013

@cpcloud please see #3893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails with clang, python3 and numpy 1.7.1 and higher
4 participants