Skip to content

CLN: consistently put '|' at start of line in pygrep hooks #39301 #39304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gustavocmaciel
Copy link
Contributor

I moved the | symbols from the end of the line to the beginning of the line in pygrep hooks.

I also added the | symbol in the non-standard-imports-in-tests at the beginning of the line 93, which was missing as @MarcoGorelli pointed.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @gcmaciel !

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 20, 2021
@jreback jreback added this to the 1.3 milestone Jan 20, 2021
@jreback jreback merged commit 7e4d331 into pandas-dev:master Jan 20, 2021
@jreback
Copy link
Contributor

jreback commented Jan 20, 2021

thanks @gcmaciel

prob need a precommit meta-hook here (heheh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI consistently put | at start of line in pygrep hooks
3 participants