-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WIP/REF: BlockManager.setitem_blockwise #39302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
…f-setitem_inplace
Hello @jbrockmendel! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Is there a specific place where I can be of help? |
Mostly just want to keep you in the loop on what i have in mind since you're working on similar parts of the code. |
Not per se a fix, but I had similar difficulties in #39341 We have to account for duplicate column names in these checks. Maybe using get_indexer_for or something like that if there is a faster alternative. Simply comparing the lenght does not work with duplicates |
You could use
as a helper functions for both len(value) != len(key) checks. Test will keep failing because the column is now cast to integer, but this is good since this is consistent with other setitem cases. If you like I could implement this in #39341. I am dispatching to the else block there right now, since this does the trick currently. |
mothballing |
Posting largely for discussion with @phofl.
Motivations:
Non-trivial overlap with #39044.
Some of this would be simplified by #39163.
No logical overlap with #39266, but will require rebase.