BUG: is_utc(dateutil_utc) #39276
Merged
BUG: is_utc(dateutil_utc) #39276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 19, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Jan 19, 2021
| @@ -1023,6 +1023,9 @@ def utc_fixture(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| utc_fixture2 = utc_fixture | |||
There was a problem hiding this comment.
Do we need this 2nd fixture here?
There was a problem hiding this comment.
good catch, wont be needed until both this and the tz_compare PR are in
There was a problem hiding this comment.
added the extra test below since the other PR got merged
mroeschke
reviewed
Jan 19, 2021
pandas/_libs/tslibs/timezones.pyx
Outdated
| @@ -30,11 +30,18 @@ from pandas._libs.tslibs.util cimport get_nat, is_integer_object | |||
| cdef int64_t NPY_NAT = get_nat() | |||
| cdef tzinfo utc_stdlib = timezone.utc | |||
| cdef tzinfo utc_pytz = UTC | |||
| cdef tzinfo utc_dateutil1 = dateutil_gettz("UTC") # NB: *not* the same as tzutc() | |||
|
can you also add a whatsnew note |
updated+green |
yah ive been seeing that occasionally recently, havent figured out whats going on there rebased + green |
mroeschke
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.