Skip to content

DOC: keep color for note admonitions in sphinx theme #39256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

This doesn't change anything about the appearance in the docs, but is meant to keep the current look anticipating a change in the default color in the theme upstream (pydata/pydata-sphinx-theme#281)

@jorisvandenbossche jorisvandenbossche added this to the 1.2.1 milestone Jan 19, 2021
@jorisvandenbossche
Copy link
Member Author

@simonjayhawkins I am going to backport this for 1.2.1, not critical but just to ensure the docs keep looking the same (needed because we are using pydata-sphinx-theme master at the moment, which we should change to a pinned version once it has a new release)

@jorisvandenbossche jorisvandenbossche merged commit 77af016 into pandas-dev:master Jan 19, 2021
@jorisvandenbossche jorisvandenbossche deleted the doc-note-color branch January 19, 2021 08:33
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 19, 2021
simonjayhawkins pushed a commit that referenced this pull request Jan 19, 2021
nofarm3 pushed a commit to nofarm3/pandas that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant