BUG: DataFrame.apply axis=1 for str ops with no axis argument #39212
Conversation
rhshadrach
commented
Jan 16, 2021
rhshadrach
commented
- closes BUG: DataFrame.apply axis=1 for str ops with no axis argument #39211
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -179,6 +179,16 @@ def test_apply_with_string_funcs(self, request, float_frame, func, args, kwds, h | |||
| expected = getattr(float_frame, func)(*args, **kwds) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "how, args", [("pct_change", ()), ("nsmallest", (1, ["a", "b"])), ("tail", 1)] | |||
| ) | |||
There was a problem hiding this comment.
does this already raise when a function is passed? ideally can you co-locate these tests.
There was a problem hiding this comment.
When function is passed, apply with axis=1 computes the correct result. E.g.
df = DataFrame([[1, 2, 3], [4, 5, 6]])
print(df.apply(lambda x: x.tail(1), axis=1))
# gives:
2
0 3
1 6
The argument axis=1 is intercepted and then apply_standard is computed on the rows of the frame without an axis argument.
There was a problem hiding this comment.
ok cool, can you co-locate this test near the others
There was a problem hiding this comment.
What is meant by others? Currently located below the other test for str arguments. Tests for axis=1 and tests that raise are fairly spread out in this file, not sure how else to locate this test.
As an aside, I've been wanting to consolidate (and then start to cleanup) the apply/agg/transform tests into pandas.tests.apply. Does that move make sense?
There was a problem hiding this comment.
ok cool
yeah would love to break up some of these test files more logically
|
thanks @rhshadrach pls create an issue (or PR!) for re-orging the apply tests :-> |
