REGR: fillna on datetime64[ns, UTC] column hits RecursionError #39194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Missing-data
nope I'll make a PR with a longer-term fix before long, but this seems like the right immediate solution |
|
thanks @simonjayhawkins |
|
@meeseeksdev backport 1.2.x |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
cc @simonjayhawkins for backport |
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jan 16, 2021
…umn hits RecursionError
simonjayhawkins
added a commit
that referenced
this pull request
Jan 16, 2021
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…s-dev#39194) * Revert "CLN: remove unnecessary DatetimeTZBlock.fillna (pandas-dev#37040)" This reverts commit 58f7468. * add test and release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbrockmendel this reverts #37040 in it's entirety for backport
feel free to push to this branch if we need any of the ancillary cleanup on 1.2.x otherwise can open a new PR to add those cleanups back to master.