Skip to content

DOC: set the documentation language #39185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

DOC: set the documentation language #39185

merged 1 commit into from
Jan 21, 2021

Conversation

afeld
Copy link
Member

@afeld afeld commented Jan 15, 2021 •
edited
Loading

Ensures the language is specified in the generated HTML. Documentation on the configuration option.

Before:

$ curl -s https://pandas.pydata.org/docs/dev/getting_started/comparison/comparison_with_spreadsheets.html | grep "<html"
<html>

After:

$ python make.py --single getting_started/comparison/comparison_with_spreadsheets.rst
$ grep "<html" build/html/getting_started/comparison/comparison_with_spreadsheets.html 
<html lang="en">
  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@afeld afeld added the Docs label Jan 15, 2021
@afeld
DOC: set the documentation language
4133a9b 
Ensures the language is specified in the generated HTML.
@jreback jreback added this to the 1.3 milestone Jan 21, 2021
@jreback
Copy link
Contributor

jreback commented Jan 21, 2021

seems fine to me. cc @datapythonista

datapythonista
datapythonista approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @afeld

@jreback jreback merged commit a0f6702 into pandas-dev:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@afeld @jreback @datapythonista