Fix regression in loc setitem raising KeyError when enlarging df with multiindex #39161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
pandas/core/indexing.py
Outdated
| if isinstance(key, tuple) and not isinstance(self.obj.index, ABCMultiIndex): | ||
| if isinstance(key, tuple) and ( | ||
| isinstance(key[0], slice) or not isinstance(self.obj.index, ABCMultiIndex) | ||
| ): | ||
| # key may be a tuple if we are .loc | ||
| # if index is not a MultiIndex, set key to column part |
There was a problem hiding this comment.
Thanks @phofl for the PR. does this comment need updating?
jreback
requested changes
Jan 14, 2021
pandas/core/indexing.py
Outdated
| @@ -662,7 +662,9 @@ def _ensure_listlike_indexer(self, key, axis=None, value=None): | |||
| if self.ndim != 2: | |||
| return | |||
|
|
|||
| if isinstance(key, tuple) and not isinstance(self.obj.index, ABCMultiIndex): | |||
| if isinstance(key, tuple) and ( | |||
There was a problem hiding this comment.
don't we need len(key) as a condition?
There was a problem hiding this comment.
wow this is a specific condition (i know i asked you to update). umm anyway we can be more general here?
There was a problem hiding this comment.
Yeah, was not happy with that either. This is better and does the job now.
jreback
approved these changes
Jan 15, 2021
|
thanks @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 15, 2021
…eyError when enlarging df with multiindex
simonjayhawkins
pushed a commit
that referenced
this pull request
Jan 15, 2021
…en enlarging df with multiindex (#39187) Co-authored-by: patrick <[email protected]>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix only viewed row indexers not column indexers