-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: implement is_exact_match #39149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: implement is_exact_match #39149
Conversation
pandas/core/indexers.py
Outdated
@@ -270,6 +270,27 @@ def maybe_convert_indices(indices, n: int): | |||
# Unsorted | |||
|
|||
|
|||
def is_exact_match(target: ArrayLike, value: ArrayLike) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe is_exact_shape_match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
bool | ||
""" | ||
return ( | ||
len(value.shape) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> 0
is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed for mypy
updated + greenish |
Working to smooth out some inconsistencies in setitem between code paths.