Skip to content

REF: implement is_exact_match #39149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

jbrockmendel
Copy link
Member

Working to smooth out some inconsistencies in setitem between code paths.

@@ -270,6 +270,27 @@ def maybe_convert_indices(indices, n: int):
# Unsorted


def is_exact_match(target: ArrayLike, value: ArrayLike) -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe is_exact_shape_match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

bool
"""
return (
len(value.shape) > 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> 0 is redundant

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for mypy

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code labels Jan 13, 2021
@jbrockmendel
Copy link
Member Author

updated + greenish

@jreback jreback added this to the 1.3 milestone Jan 14, 2021
@jreback jreback merged commit 8022743 into pandas-dev:master Jan 14, 2021
@jbrockmendel jbrockmendel deleted the ref-setitem-exact-match branch January 14, 2021 15:33
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants