Skip to content

BUG: Series.__setitem__ with mismatched IntervalDtype #39120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 15, 2021
Merged

BUG: Series.__setitem__ with mismatched IntervalDtype #39120

merged 6 commits into from
Jan 15, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 12, 2021 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback requested changes Jan 13, 2021
View reviewed changes
pandas/tests/internals/test_internals.py
if inplace:
assert df._mgr.blocks[0].values is arr # i.e. setting was done inplace
else:
assert df.dtypes[0] == object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should think about breaking up this test file at some point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill take a look at some point. we'll get to delete the test class below in #35417, so thats a start

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type labels Jan 13, 2021
@jreback
Copy link
Contributor

jreback commented Jan 13, 2021

also pls add a whatsnew

@jreback jreback added this to the 1.3 milestone Jan 14, 2021
jreback
jreback approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can you merge master just in case and ping on greenish

@jbrockmendel
Copy link
Member Author

rebased + greenish

@jreback jreback merged commit 0b62e86 into pandas-dev:master Jan 15, 2021
@jbrockmendel jbrockmendel deleted the ref-hybrid_block-2 branch January 15, 2021 15:18
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
BUG: Series.__setitem__ with mismatched IntervalDtype (pandas-dev#39120)
d3dc5c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback