TYP: fix mypy error in pandas/core/common.py #39106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| if isinstance(values, (list, np.ndarray, ABCIndex, ABCSeries, ABCExtensionArray)): | ||
| # np.ndarray resolving as Any gives a false positive | ||
| return values # type: ignore[return-value] | ||
| return cast(Union[List, AnyArrayLike], values) |
There was a problem hiding this comment.
The comment above indicates that this ignore can be removed after we have numpy types. no need to add cast yet. While numpy types resolve to Any and np.ndarray is part of AnyArrayLike we may have false positives.
There was a problem hiding this comment.
Ok, thank you for the clarification.
So, probably this PR should be closed?
There was a problem hiding this comment.
the changes to the docstring are ok, but I'll close this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle ignored mypy error in
pandas/core/common.py.