Skip to content

REF: Remove Apply.get_result #39082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

REF: Remove Apply.get_result #39082

merged 1 commit into from
Jan 11, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Slightly simpler and allows typing of the result that we get out of Apply. Having both apply and agg go through get_result would mean typing the result as Union[FrameOrSeriesUnion, Tuple[bool, Optional[FrameOrSeriesUnion]]]

@rhshadrach rhshadrach added Refactor Internal refactoring of code Apply Apply, Aggregate, Transform, Map labels Jan 10, 2021
@jreback jreback added this to the 1.3 milestone Jan 10, 2021
@jreback jreback merged commit ec4a644 into pandas-dev:master Jan 11, 2021
@rhshadrach rhshadrach deleted the apply_remove_get_result branch January 11, 2021 14:32
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@rhshadrach @luckyvs1
REF: Remove Apply.get_result (pandas-dev#39082)
03eb548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @jreback