TST GH26807 Break up pandas/tests/io/pytables/test_store.py #39072
Conversation
… test_file_handling
….single decorator to all new classes
|
Hello @moink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-01-13 17:00:26 UTC |
moink
added
IO HDF5
|
this is a straight move right? e.g. no actual changes except to make tests / linting pass? |
Correct. I made no changes at all to the tests - just moved existing ones to other classes & modules. |
…est_read into test_errors
| @pytest.mark.filterwarnings( | ||
| "ignore:\\nthe :pandas.io.pytables.AttributeConflictWarning" | ||
| ) | ||
| def test_coordinates(setup_path): |
There was a problem hiding this comment.
I don't know what's going on with this test. I had intermittent failures on my computer, and then it failed in the Windows CI. I had a really hard time trying to debug this test because the failure was intermittent.
There was a problem hiding this comment.
Seems to have a common cause with #32225
|
looks good. can you merge master (small conflict), and show the before/after test count. ping when ready |
|
273 tests in pandas/tests/io/pytables both before and after the changes |
|
thanks @moink |
This PR addresses xref #26807 for pandas/tests/io/pytables/test_store.py, which was more than 5000 lines before this attempt. I made a new directory pandas/tests/io/pytables/store/ to put all the new modules in. I tried to 1) get all the new modules below 1000 lines and 2) break it up in a somewhat logical way, but let's see if I succeeded in the opinion of the reviewer.
There were 194 tests in pandas/tests/io/pytables/test_store.py, and now there are 194 tests in pandas/tests/io/pytables/store so I haven't gained or lost any. One is skipped on my dev machine.