Skip to content

TYP: PeriodArray._unbox_scalar #39070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

mypy errors with numpy 1.20

pandas/core/arrays/period.py:273: error: Return type "int" of "_unbox_scalar" incompatible with return type "Union[signedinteger[_64Bit], datetime64, timedelta64]" in supertype "DatetimeLikeArrayMixin" [override]
pandas/core/arrays/period.py:277: error: Incompatible return value type (got "signedinteger[_64Bit]", expected "int") [return-value]
pandas/core/arrays/period.py:280: error: Incompatible return value type (got "signedinteger[_64Bit]", expected "int") [return-value]

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jan 9, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jan 9, 2021
@jreback jreback merged commit eead40e into pandas-dev:master Jan 9, 2021
@simonjayhawkins simonjayhawkins deleted the PeriodArray._unbox_scalar branch January 10, 2021 09:32
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants