Skip to content

TYP: prep _generate_range_overflow_safe for numpy 1.20 #39067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

TYP: prep _generate_range_overflow_safe for numpy 1.20 #39067

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b25c12
TYP: prep _generate_range_overflow_safe for numpy 1.2
simonjayhawkins Jan 9, 2021
a7bea7d
remove problematic type annotations for now
simonjayhawkins Jan 11, 2021
b3e95b7
Merge remote-tracking branch 'upstream/master' into _generate_range_o…
simonjayhawkins Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/core/arrays/_ranges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def generate_regular_range(

def _generate_range_overflow_safe(
endpoint: int, periods: int, stride: int, side: str = "start"
) -> int:
):
"""
Calculate the second endpoint for passing to np.arange, checking
to avoid an integer overflow. Catch OverflowError and re-raise
Expand All @@ -89,7 +89,7 @@ def _generate_range_overflow_safe(

Returns
-------
other_end : int
np.integer

Raises
------
Expand Down Expand Up @@ -137,7 +137,7 @@ def _generate_range_overflow_safe(

def _generate_range_overflow_safe_signed(
endpoint: int, periods: int, stride: int, side: str
) -> int:
):
"""
A special case for _generate_range_overflow_safe where `periods * stride`
can be calculated without overflowing int64 bounds.
Expand Down