Skip to content

Added docs for the change of behavior of isin #39064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2021
Merged

Added docs for the change of behavior of isin #39064

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94095c7
Added docs for the change of behavior of isin
omarafifii Jan 9, 2021
7d36f0f
updated docs for isin
omarafifii Jan 10, 2021
cd13e57
update docs for isin
omarafifii Jan 14, 2021
86f0e86
lint
simonjayhawkins Jan 16, 2021
bc3a00c
Merge remote-tracking branch 'upstream/master' into issue-#38781
simonjayhawkins Jan 16, 2021
22fe1ff
doctest fix
simonjayhawkins Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4630,6 +4630,17 @@ def isin(self, values) -> "Series":
4 True
5 False
Name: animal, dtype: bool

.. versionchanged:: 1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't neeed the version added.
Also reword this to.

Strings and integers are distinct and are therefore not comparable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
I wanted to ask why are some of the checks failing? Am I doing something wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click thru to see why these are failign: https://github.com/pandas-dev/pandas/pull/39064/checks?check_run_id=1703810526

for example

Strings and integers are now treated as distinct. This new behaviour caused some tests to fail because users where unaware of this change.

>>>import pandas as pd
pd.Series([1]).isin(['1'])
0 False
dtype: bool
pd.Series([1.1]).isin(['1.1'])
0 False
dtype: bool
"""
result = algorithms.isin(self._values, values)
return self._constructor(result, index=self.index).__finalize__(
Expand Down