TYP: series apply method adds type hints #39058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aniaan
commented
Jan 9, 2021
aniaan
commented
- Ensure all linting tests pass, see here for how to run them
pandas/core/series.py
Outdated
| def apply(self, func, convert_dtype=True, args=(), **kwds): | ||
| def apply( | ||
| self, func: AggFuncType, convert_dtype: bool = True, args: tuple = (), **kwds | ||
| ): |
There was a problem hiding this comment.
Suggested change
| ): | |
| ) -> FrameOrSeriesUnion: |
pandas/core/series.py
Outdated
| @@ -3979,7 +3979,9 @@ def transform( | |||
| ) -> FrameOrSeriesUnion: | |||
| return transform(self, func, axis, *args, **kwargs) | |||
|
|
|||
| def apply(self, func, convert_dtype=True, args=(), **kwds): | |||
| def apply( | |||
| self, func: AggFuncType, convert_dtype: bool = True, args: tuple = (), **kwds | |||
There was a problem hiding this comment.
use Tuple from typing and add type parameters where possible
Suggested change
| self, func: AggFuncType, convert_dtype: bool = True, args: tuple = (), **kwds | |
| self, func: AggFuncType, convert_dtype: bool = True, args: Tuple[Any] = (), **kwds |
Corrected, please take a look |
|
see https://github.com/pandas-dev/pandas/runs/1673701200 for mypy failures |
|
CI has passed, please take a look |
|
can you merge master; your changes will now work in pandas/core/apply.py where thing were moved. |
|
Updated, but there was a slight problem with the CI that doesn't seem to be related to this commit |
yep, unrelated. |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.