CLN, TYP use from __future__ import annotations #39036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Thanks @MarcoGorelli lgtm pending green.
Not yet figured out how to write a good automated check for this
yep. last year there was alot of activity on manually migrating to f-strings, only for a tool to come along that would have did it for us.
|
see also #36091 |
|
@MarcoGorelli I'll merge this now as without a check it's a waste of valuable reviewer time to check that all quotes are removed from a module when the import is added. but there we a few here that are obvious without a through check. |
| @@ -322,7 +324,7 @@ def should_reindex_frame_op( | |||
|
|
|||
|
|
|||
| def frame_arith_method_with_reindex( | |||
| left: "DataFrame", right: "DataFrame", op | |||
| left: DataFrame, right: DataFrame, op | |||
| ) -> "DataFrame": | |||
| @@ -139,7 +141,7 @@ def melt( | |||
|
|
|||
|
|
|||
| @deprecate_kwarg(old_arg_name="label", new_arg_name=None) | |||
| def lreshape(data: "DataFrame", groups, dropna: bool = True, label=None) -> "DataFrame": | |||
| def lreshape(data: DataFrame, groups, dropna: bool = True, label=None) -> "DataFrame": | |||
| @@ -234,7 +236,7 @@ def lreshape(data: "DataFrame", groups, dropna: bool = True, label=None) -> "Dat | |||
|
|
|||
|
|
|||
| def wide_to_long( | |||
| df: "DataFrame", stubnames, i, j, sep: str = "", suffix: str = r"\d+" | |||
| df: DataFrame, stubnames, i, j, sep: str = "", suffix: str = r"\d+" | |||
|
a separate PR dealing with return types is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing as pandas is Python3.7+ we can clean up some annotations. Not yet figured out how to write a good automated check for this, but here's a start